Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sort #1706

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix sort #1706

wants to merge 2 commits into from

Conversation

jony89
Copy link

@jony89 jony89 commented Feb 15, 2018

since the logic depeneds on the values being sorted correctly (arrayA[ai] < arrayB[bi]) and .sort is not stable and even gives a wrong result according to decimal computation( [14,2].sort() = [14,2], so we must at least give the compareFunction for simple cases

since the logic depeneds on the values being sorted correctly (`arrayA[ai] < arrayB[bi]`) and .sort is not stable and even gives a wrong result according to decimal computation( [14,2].sort() = [14,2], so we must at least give the `compareFunction` for simple cases
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants